fix(util-genai): remove deprecated methods from handler.py - #300
Draft
bhumikadangayach wants to merge 2 commits into
Draft
fix(util-genai): remove deprecated methods from handler.py#300bhumikadangayach wants to merge 2 commits into
bhumikadangayach wants to merge 2 commits into
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-07-28 02:18 UTC Move out of draft to request review. Doesn't look right?
|
bhumikadangayach
force-pushed
the
remove-deprecated-genai-methods
branch
from
July 22, 2026 06:27
84eb3f4 to
9eda96b
Compare
… stale tests, add changelog Still waiting on lmolkova's deprecation-window policy answer on open-telemetry#246 before opening a PR.
bhumikadangayach
force-pushed
the
remove-deprecated-genai-methods
branch
from
July 23, 2026 14:52
9eda96b to
e500732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #246
Summary
Removes the 9 deprecated methods from util-genai's handler.py, along with their stale references elsewhere in the codebase.
What changed
Removed all 9 deprecated methods: start_inference, start_llm, start_embedding, start_tool, start_workflow, stop_llm, fail_llm, start_invoke_local_agent, start_invoke_remote_agent
Renamed 8 stale test function names to match the current API (e.g. test_start_workflow_* → test_workflow_*)
Fixed 2 stale docstring references in _inference_invocation.py
Added a changelog fragment
Verification
Checked usage across all instrumentation packages and the shared test-util package before removing — none call these deprecated methods anymore, only docstrings/comments referenced them. 234 tests passing locally, typecheck and precommit clean.
Why draft
Opened as draft since I haven't gotten a response yet on whether a deprecation-window policy should apply before this kind of removal (asked on #246). Keeping this open for visibility and review — happy to adjust scope or timing based on what's preferred.