[API/SDK] add WITH_LOG_FILTERING_PREVIEW option#4160
Conversation
WITH_LOG_FILTERING_PREVIEW preview option
WITH_LOG_FILTERING_PREVIEW preview optionWITH_LOG_FILTERING_PREVIEW option
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
+ Coverage 82.82% 82.84% +0.02%
==========================================
Files 406 406
Lines 16913 16909 -4
==========================================
Hits 14007 14007
+ Misses 2906 2902 -4
🚀 New features to boost your workflow:
|
Co-authored-by: Marc Alff <marc.alff@free.fr>
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the patch.
See questions, for my own understanding, I don't grasp the rationale behind it.
| endif() | ||
|
|
||
| if(WITH_LOG_FILTERING_PREVIEW) | ||
| target_compile_definitions(opentelemetry_api |
There was a problem hiding this comment.
In this case, the flag should be renamed to OPENTELEMETRY_ENABLE_LOG_FILTERING_PREVIEW to avoid polluting the user build, and how to do a build in the user application should be documented with clarity.
@marcalff since all these preview flags are set with INTERFACE they will transit publicly to any targets that link to the opentelemetry-cpp::api target. If we apply a prefix it likely should be applied to all public definitions. Could this be a follow up PR?
Follow up to #4079 (comment)
Changes
WITH_LOG_FILTERING_PREVIEWoption to guard the new log record filtering behaviorFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes