Skip to content

perf: replace copy+reverse with index-based traversal in executeBefor… #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobias-ibounig-dt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: replace copy+reverse with index-based traversal in executeBefor… #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/dev/openfeature/sdk/HookSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package dev.openfeature.sdk;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -51,10 +50,9 @@

public void executeBeforeHooks(HookSupportData data) {
// These traverse backwards from normal.
List<Pair<Hook, HookContext>> reversedHooks = new ArrayList<>(data.getHooks());
Collections.reverse(reversedHooks);

for (Pair<Hook, HookContext> hookContextPair : reversedHooks) {
List<Pair<Hook, HookContext>> hooks = data.getHooks();

Check warning on line 53 in src/main/java/dev/openfeature/sdk/HookSupport.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 


See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ6W6Szz5LH9ucI5lnkG&open=AZ6W6Szz5LH9ucI5lnkG&pullRequest=1954

Check warning on line 53 in src/main/java/dev/openfeature/sdk/HookSupport.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 


See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ6W6Szz5LH9ucI5lnkH&open=AZ6W6Szz5LH9ucI5lnkH&pullRequest=1954
for (int i = hooks.size() - 1; i >= 0; i--) {
Comment on lines +53 to +54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential NullPointerExceptions, it is recommended to add a defensive null check for data and data.getHooks(). Since HookSupportData is initialized with a default constructor where hooks is not set, data.getHooks() can return null if no hooks are registered or if setHooks was not called.

Suggested change
List<Pair<Hook, HookContext>> hooks = data.getHooks();
for (int i = hooks.size() - 1; i >= 0; i--) {
if (data == null || data.getHooks() == null) {
return;
}
List<Pair<Hook, HookContext>> hooks = data.getHooks();
for (int i = hooks.size() - 1; i >= 0; i--) {

var hookContextPair = hooks.get(i);
var hook = hookContextPair.getKey();
var hookContext = hookContextPair.getValue();

Expand Down