Add tests for ONNX function preservation in optimizer - #317
Open
take-cheeze wants to merge 1 commit into
Open
Conversation
take-cheeze
force-pushed
the
claude/onnx-function-test-optimizer-n5vi9t
branch
2 times, most recently
from
July 24, 2026 03:29
4f07d21 to
4f67824
Compare
Add tests verifying that onnxoptimizer.optimize preserves model-local functions. Unlike the approach in onnx#199, which relied on torch.onnx.export(export_modules_as_functions=...) (a deprecated legacy exporter feature), these tests build functions directly with onnx.helper.make_function and the onnx text parser, matching the existing test idioms and avoiding a torch/torchvision dependency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0162JuH5K5FP2hCFYJRrKC49 Signed-off-by: Takeshi Watanabe <takechi101010@gmail.com> Signed-off-by: take-cheeze <takechi101010@gmail.com>
take-cheeze
force-pushed
the
claude/onnx-function-test-optimizer-n5vi9t
branch
from
July 24, 2026 05:14
4f67824 to
df6d6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests verifying that onnxoptimizer.optimize preserves model-local functions. Unlike the approach in #199, which relied on torch.onnx.export(export_modules_as_functions=...) (a deprecated legacy exporter feature), these tests build functions directly with onnx.helper.make_function and the onnx text parser, matching the existing test idioms and avoiding a torch/torchvision dependency.
closes #194
Claude-Session: https://claude.ai/code/session_0162JuH5K5FP2hCFYJRrKC49