Skip to content

fix(terminal): coalesce scroll events #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarluq merged 3 commits into from
Jul 2, 2026
Merged

fix(terminal): coalesce scroll events #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03b4aa2
fix(terminal): coalesce scroll events
omarluq Jul 2, 2026
8b2581d
fix(terminal): preserve dirty state during scroll coalescing
omarluq Jul 2, 2026
3607439
test(terminal): assert dirty frame rendering
omarluq Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/terminal/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,10 @@ func (app *App) handleLoopEvent(ctx context.Context, event tcell.Event) (shouldQ
return app.drawLatestResize(ctx, resize)
}

if delta, ok := app.scrollDeltaForEvent(event); ok {
return app.handleScrollLoopEvent(ctx, delta)
}

shouldQuit, err := app.handleEvent(ctx, event)
if err != nil {
app.addMessage(transcript.RoleCustom, err.Error())
Expand All @@ -408,6 +412,18 @@ func (app *App) handleLoopEvent(ctx context.Context, event tcell.Event) (shouldQ
return false, true
}

func (app *App) handleScrollLoopEvent(ctx context.Context, delta int) (shouldQuit, dirty bool) {
coalesced := app.coalesceScrollEvents(delta)
app.scrollTranscript(coalesced.Delta)
app.draw(ctx)

if coalesced.Pending != nil {
return app.handleLoopEvent(ctx, coalesced.Pending)
}

return false, false
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

func (app *App) drawLatestResize(ctx context.Context, resize *tcell.EventResize) (shouldQuit, dirty bool) {
pending := app.coalesceResizeEvents(resize)
if pending.Resize != nil {
Expand Down
Loading
Loading