fix(example): bound multimodal xkcd requests - #717
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
examples/multimodal-generate.pyfetches xkcd metadata and the comic image usinghttpx.get()without explicit timeouts. If xkcd or the image host accepts a connection but stalls, the example can hang before it ever reaches the Ollama generation call.Before / after behavior
Before, the example made three external HTTP requests without a local timeout at the call sites.
After, the example uses one small
HTTP_TIMEOUTconstant for the latest-comic lookup, selected-comic lookup, and image download. The existingraise_for_status()behavior is unchanged.Verification
python -m ruff format examples/multimodal-generate.pypython -m ruff check examples/multimodal-generate.pypython -m py_compile examples/multimodal-generate.pygit diff --checkI did not run the example end-to-end because it requires a local Ollama
llavamodel and live network calls.