Skip to content

Detect the PHPUnit runner for MediaWiki 1.46+ #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malberts merged 2 commits into from
Jun 11, 2026
+27 −7
Merged

Detect the PHPUnit runner for MediaWiki 1.46+ #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1bf21
CI: detect the PHPUnit runner and add MediaWiki 1.46
malberts Jun 11, 2026
4c30fd4
tests: extend Scribunto's namespaced LuaEngineTestBase
malberts Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
php: 8.3
type: normal
experimental: false
- mw: 'master'
- mw: 'REL1_46'
php: 8.4
type: normal
experimental: true
Expand Down Expand Up @@ -95,12 +95,32 @@ jobs:
run: bash EarlyCopy/.github/workflows/uploadImages.sh

- if: env.TYPE != 'coverage'
name: Run PHPUnit w/o coverage
run: php tests/phpunit/phpunit.php -c extensions/BootstrapComponents/ --testsuite bootstrap-components-unit
name: Run PHPUnit
run: |
if [ -f tests/phpunit/phpunit.php ]; then
php tests/phpunit/phpunit.php -c extensions/BootstrapComponents/ --testsuite bootstrap-components-unit
else
# MW 1.46 and later
if [ ! -f phpunit.xml.template ]; then
wget -q -O phpunit.xml.template "https://raw.githubusercontent.com/wikimedia/mediawiki/${{ matrix.mw }}/phpunit.xml.template"
fi
composer phpunit:config
vendor/bin/phpunit -c phpunit.xml extensions/BootstrapComponents/tests/phpunit/Unit
fi

- if: env.TYPE == 'coverage'
name: Run PHPUnit w/ coverage
run: php tests/phpunit/phpunit.php -c extensions/BootstrapComponents/ --testsuite bootstrap-components-unit --coverage-clover coverage.clover
name: Run PHPUnit (coverage)
run: |
if [ -f tests/phpunit/phpunit.php ]; then
php tests/phpunit/phpunit.php -c extensions/BootstrapComponents/ --testsuite bootstrap-components-unit --coverage-clover coverage.clover
else
# MW 1.46 and later
if [ ! -f phpunit.xml.template ]; then
wget -q -O phpunit.xml.template "https://raw.githubusercontent.com/wikimedia/mediawiki/${{ matrix.mw }}/phpunit.xml.template"
fi
composer phpunit:config
vendor/bin/phpunit -c phpunit.xml extensions/BootstrapComponents/tests/phpunit/Unit --coverage-clover coverage.clover
fi

- if: env.TYPE == 'coverage'
name: upload coverage report
Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/Unit/LuaLibraryTestBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace MediaWiki\Extension\BootstrapComponents\Tests\Unit;

use MediaWiki\Extension\BootstrapComponents\LuaLibrary;
use Scribunto_LuaEngineTestBase;
use MediaWiki\Extension\Scribunto\Tests\Engines\LuaCommon\LuaEngineTestBase;

/**
* @ingroup Test
Expand All @@ -15,7 +15,7 @@
* @since 1.1
* @author Tobias Oetterer
*/
abstract class LuaLibraryTestBase extends Scribunto_LuaEngineTestBase
abstract class LuaLibraryTestBase extends LuaEngineTestBase
{
/**
* @var LuaLibrary
Expand Down
Loading