19.0 tutorials amtha by amtha-odoo · Pull Request #1376 · odoo/tutorials

amtha-odoo · 2026-07-29T07:16:04Z

Created Estate module and models
Added list, form, and search views
Configured menus, actions, and security
Implemented model relationships (Many2one, One2many, Many2many)
Added computed fields, inverse methods, and onchange logic
Implemented property and offer business actions (Sold, Cancel, Accept, Refuse)
Added validations and state management
Updated property buyer and selling price on offer acceptance

Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.

…e(csv)

Introduce the initial user interface for the estate module by defining the window action and menu hierarchy required to access property records from the Odoo web client. This change makes the estate.property model accessible through the application, providing the foundation for interacting with records using the default list and form views before introducing custom views in later chapters. The property model is also improved by configuring field attributes and defaults. Read-only and copy behaviors are defined for system-managed fields, default values are added to reduce manual data entry, and the reserved active and state fields are introduced to support record archiving and future workflow-related features.

Replace the automatically generated views with custom list and form views to provide a clearer and more user-friendly interface for managing estate properties. The custom views organize the property information into logical groups, making property creation and editing easier while exposing the most important fields directly from the list view. This change prepares the module for future UI enhancements such as custom search views, buttons and advanced form layouts introduced in later chapters.

…nifest file

-compute the total-area of the property -compute the best-price of the property using private methods -compute the deadline from create_date and validity -implement an inverse method to update validity from the deadline -handle record creation by providing a fallback when create_date is not yet available -display the new fields in the offer tree and form views

robodoo · 2026-07-29T07:16:06Z

…operty type and tag

…ice, use float_is_zero() and float_compare())

mash-odoo

Hello,
Good start on the task.
I have added some comments and suggestions.
Some points to be looked at:

Do not leave unnecessary lines between fields.
Reformat the files according to the coding guidelines.
Add description and chapter name while pushing the commits in order to understand the changes done for that particular commit.
Update the PR title.

mash-odoo · 2026-08-13T05:14:53Z

+# estate/models/__init__.py
+
+from . import estate_property


Suggested change

# estate/models/__init__.py

from . import estate_property

from . import estate_property

mash-odoo · 2026-08-13T05:17:18Z

+    _order = "name asc"
+
+    name = fields.Char(required=True)
+    total_area = fields.Integer(compute="_compute_total_area")
+
+    @api.depends("living_area", "garden_area")
+    def _compute_total_area(self):
+        for record in self:
+            record.total_area = record.living_area + record.garden_area


Please refer to this for proper ordering of attributes in a model

mash-odoo · 2026-08-13T06:00:32Z

+    property_type_id = fields.Many2one(
+        "estate.property.type",
+        string="Property Type",
+    )
+
+    buyer_id = fields.Many2one(
+        "res.partner",
+        string="Buyer",
+        copy=False,
+    )
+    salesperson_id = fields.Many2one(
+        "res.users",
+        string="Salesperson",
+        default=lambda self: self.env.user,


You don't need to add string explicitly if you want it to be similar to the field name itself.

Remove string attributes from fields where the default field label is already appropriate.

/home/odoo/odoo19/community/odoo/orm/fields.py line no. = 508 =>Odoo automatically generates the UI label from the field's technical name.

mash-odoo · 2026-08-13T06:07:02Z

+    garden_orientation = fields.Selection(
+        [
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
+        ]
+    )


Suggested change

garden_orientation = fields.Selection(

[

("north", "North"),

("south", "South"),

("east", "East"),

("west", "West"),

]

)

garden_orientation = fields.Selection(

[

('north', "North"),

('south', "South"),

('east', "East"),

('west', "West"),

]

)

Try to keep the key i.e the technical strings in single quotes and the values which are to be displayed to the user in double quotes

mash-odoo · 2026-08-13T06:08:35Z

+                )
+                < 0
+            ):
+                raise ValidationError(


When would you raise UserError and ValidationError?
What is the difference between both of them?

UserError : use when the user perform invalid action.usually use in button and action methods and stop the current operation
ValidationError : use when data violates a validation.prevents invalid data from being saved.

Both will show an error popup to the user, but UserError is used when a user performs an action that is not allowed, and ValidationError is used when entered or modified data fails a validation

mash-odoo · 2026-08-13T06:11:09Z

+        </field>
+    </record>
+
+</odoo>


Always leave an extra line at the end of the file.

mash-odoo · 2026-08-13T06:11:30Z

+                <field name="partner_id"/>
+                <field name="validity"/>
+                <field name="deadline"/>
+                <button name="action_confirm" string="Confirm" type="object" icon="fa-check"/>


When to use type object and type action?

type = "object" : used when execute python method defined on the model.
type = "action" : used when execute an odoo action identified by its external ID.

mash-odoo · 2026-08-13T06:12:21Z

+    "depends": ["base"],
+    "application": True,
+    "category": "Tutorials",
+    "author": "Thakor Anish",


When you are working for a company, you should keep the author name as Odoo S.A. or just skip writing it.

mash-odoo · 2026-08-13T06:12:38Z

+    "application": True,
+    "category": "Tutorials",
+    "author": "Thakor Anish",
+    "license": "LGPL-3",


What other options are there for licensing?

/home/odoo/odoo19/community/odoo/addons/base/models/ir_module.py == line no. : 296

GPL-2,GPL-3,AGPL-3,LGPL-3,OEEL-1,OPL-1

mash-odoo · 2026-08-13T06:15:23Z

+    best_price = fields.Float(
+        string="Best Offer",
+        compute="_compute_best_price",
+        store=True,


Why do we need to store this value?

For a calculated field, use store=True to store the value in the database. but here we don't need to store this value here, so I removed store=True.

- Fix line spacing - Reorder model attributes and methods - Remove unnecessary field string attributes - Update selection technical values to single quotes - Add trailing newline at end of files - Update author name - Remove unnecessary store=True from best_price

amtha-odoo added 17 commits July 2, 2026 18:11

[ADD] estate: initial module setup

d87cc90

Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.

[IMP] estate: added estate_property model

350ef88

[LINT] Fix Code Formatting

bdaafbc

[LINT] Fix Code Formatting and add module license

95e2760

[LINT] Fix Code Formatting and add lincense data and add security fil…

5371919

…e(csv)

[LINT] Fix Code Formatting and add lincense data and add security fil…

f888899

…e(csv)

[IMP] estate: Add search view for estate properties

7481584

[ADD] estate: add property type model and relation

5da110c

[IMP] estate: add menus for property type and tag and custom search view

9533150

[IMP] estate: add security access rules and update __init__.py and ma…

bab61c0

…nifest file

[IMP] estate: Add property types, tags, offers, and model relations

f9dce55

[IMP] estate: Add computed total_area field using @api.depends

9f22c07

[IMP] estate: Add actions for property and offer management

9d5c18a

amtha-odoo requested a review from mash-odoo July 29, 2026 07:16

amtha-odoo added 3 commits July 31, 2026 18:24

[IMP] estate: add Sql constraints for selling price,expected price,pr…

cb60158

…operty type and tag

[LINT] estate: fix check type error

05d7e93

[IMP] estate: add python constrains for selling price and expected pr…

26ccc80

…ice, use float_is_zero() and float_compare())

amtha-odoo force-pushed the 19.0-tutorials-amtha branch from 6c89568 to 26ccc80 Compare August 11, 2026 12:48

mash-odoo requested changes Aug 13, 2026

View reviewed changes

amtha-odoo force-pushed the 19.0-tutorials-amtha branch from 2333d73 to b00f3b5 Compare August 13, 2026 11:36

Uh oh!

Conversation

amtha-odoo commented Jul 29, 2026

Uh oh!

robodoo commented Jul 29, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants