Add aarch64-unknown-linux-musl target#232
Open
frejsoya wants to merge 1 commit into
Open
Conversation
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
from
ebc522e to
0b09c50
Compare
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
2 times, most recently
from
5af543d to
aaa51df
Compare
We build static musl Dune binaries for x86_64 but not ARM64, so anyone on Graviton, Ampere, or an Apple Silicon Linux VM is stuck building from source. This adds the same static build for ARM64, running natively on the ubuntu-22.04-arm runner. Signed-off-by: Frej Soya <frej.soya@gmail.com>
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
from
aaa51df to
b42b022
Compare
Leonidas-from-XIV
requested review from
Leonidas-from-XIV,
Sudha247 and
shonfeder
Contributor
|
Good to see you, @frejsoya! We had an issue with the formatting but if you rebase your PR then that should work again. Can you do a run on your fork to show that the ARM64 binary on Linux is successfully passing the test? It will fail to upload to our infrastructure but it would be good seeing that the produced binary is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static dune binaries (musl) for ARM64 Linux.