Skip to content

Codex/ble control diagnostics - #523

Open
HuagoSR wants to merge 45 commits into
ob-f:masterfrom
ISIP-CART:codex/ble-control-diagnostics
Open

Codex/ble control diagnostics#523
HuagoSR wants to merge 45 commits into
ob-f:masterfrom
ISIP-CART:codex/ble-control-diagnostics

Conversation

@HuagoSR

@HuagoSR HuagoSR commented Jul 12, 2026

Copy link
Copy Markdown

No description provided.

HuagoSR and others added 30 commits July 2, 2026 15:09
@thias15

thias15 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks for sharing this. Before we go further — is this intended as a contribution to the main OpenBot repo, or was it opened on the wrong repository? The feature adds a cart-following prototype that depends on custom non-standard firmware (CART_AT8236), which makes it unclear whether it is meant for general use here.

If this is intended for this repo, here is what needs to be addressed before it can be reviewed:

1. Add a PR description. There is currently none. Explain what the feature does, what hardware/firmware it requires, and how to test it.

2. Remove the developer log files. android/cartfollow-devlog.md (1 169 lines) and android/point_goal_navigation_source_analysis.md are personal notes and do not belong in the repo.

3. Translate all user-facing strings to English. HumanCommandInterpreter contains hardcoded Chinese-only strings shown in the UI. OpenBot is an international project — English is the baseline, with translations going through strings.xml.

4. Gate the new menu entries. Four new tiles are added to the main app menu for all users, but the feature requires non-standard firmware. They should only appear when the connected device identifies as the expected firmware type, or be hidden behind a developer flag.

5. Split the PR. The BLE queue/reliability improvements (BleSerialWriteQueue, BluetoothManager refactor, the duplicate initBle() fix) are independent of the cart-follow feature and could be merged on their own. A 10 000-line PR mixing infrastructure, a new feature module, and data collection tools is very difficult to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants