chore(deps-dev): bump vite from 5.4.21 to 6.4.2#58
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.21 to 6.4.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v6.4.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v6.4.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.4.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
AaronDDM
left a comment
There was a problem hiding this comment.
This is a Vite 5 → Vite 6 major bump and as-is it'll almost certainly break builds and tests. A few coupled bumps are missing:
1. vite-plugin-dts ^3.7.0 is incompatible with Vite 6.
vite-plugin-dts v3 only supports Vite ≤ 5. For Vite 6 you need vite-plugin-dts ^4.x. Both packages/react/package.json and packages/nylas-connect/package.json still pin vite-plugin-dts ^3.7.0 on this branch, so the build step will fail or silently miss type emission.
2. vitest ^2.1.8 (and @vitest/coverage-v8 ^2.1.9) are not aligned with Vite 6.
Vitest 2 was built against Vite 5; Vitest 3 is the version aligned with Vite 6. Running the test suite under this branch will likely produce peer warnings at best and resolution failures at worst.
3. Merge conflicts.
mergeable_state is dirty. The lockfile changes here are large (~640 lines), so even after fixing (1) and (2) you'll need a fresh rebase.
4. Vite 6 has real breaking changes.
Most notably the new Environment API and changes to default legacy/SSR behavior. The two affected packages should at minimum get a smoke build + test run after the upgrade.
I'd suggest either:
- (a) Combine this PR with bumps to
vite-plugin-dts@^4andvitest@^3(and re‑runpnpm install/ build / test), or - (b) Close this and let Dependabot regenerate it once those companion bumps are in place.
Requesting changes.
Bumps vite from 5.4.21 to 6.4.2.
Release notes
Sourced from vite's releases.
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
6b3fad0release: v6.4.2ca4da5dfix: avoid path traversal with optimize deps sourcemap handler (#22161)fe28e47fix: apply server.fs check to env transport (#22159) (#22163)5487f4frelease: v6.4.11114b5dfix(dev): trim trailing slash beforeserver.fs.denycheck (#20968) (#20969)f12697crelease: v6.4.0ca6455efeat: allow passing down resolved config to vite's createServer (#20932)0e173d8release: v6.3.7c59a222fix(esbuild): inject esbuild helpers correctly for esbuild 0.25.9+ (#20940)3f337c5release: v6.3.6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.