Skip to content

Enable and fix for dark mode #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alphapapa wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Enable and fix for dark mode #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82b481a
Revert "Disable dark mode temporarily"
alphapapa Dec 7, 2023
a5cb5e4
Fix: (.scientific-domains ... img) Invert for dark-mode
alphapapa Dec 7, 2023
2d96ad8
Fix: (img.first-column-layout) Invert "Array libraries" logos
alphapapa Dec 7, 2023
f8005fe
Change/Fix: Invert all tabs' images for dark mode
alphapapa Dec 7, 2023
7621707
Fix: Remove stray LI bullet
alphapapa Dec 7, 2023
1a9fe8d
Fix: Tabs' contents' top margin
alphapapa Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions assets/css/tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ table td, table th {
.tabs-section {
display: flex;
flex-direction: column;

html[data-theme=dark] & img {
filter: invert(1) !important;
Copy link
Copy Markdown

@shoumikchakravarty-dev shoumikchakravarty-dev May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invert(1) is a brute-force visual hack that doesn't scale. Try class-based escape by adding no-invert would let individual images opt out

}

& .tabs div li {
Copy link
Copy Markdown

@shoumikchakravarty-dev shoumikchakravarty-dev May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks to be unrelated to this PR

display: inline;

& .grid-container {
margin-top: 1em;

& p {
margin-top: 0em;
}
}
}
}

.tabs-section .container {
Expand Down Expand Up @@ -109,6 +125,10 @@ section.scientific-domains {
width: 50px;
height: 50px;
margin-bottom: 0.5em;

html[data-theme=dark] & {
Copy link
Copy Markdown

@shoumikchakravarty-dev shoumikchakravarty-dev May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html[data-theme="dark"] is the recommended convention

filter: invert(1) grayscale(1) !important;
}
}
& ul {
align-content: left;
Expand Down
1 change: 0 additions & 1 deletion config.yaml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ markup:
disableLanguages: []

params:
colorScheme: light
author:
name: "NumPy team"
images:
Expand Down