Skip to content

fix(tests): pin test_runtime WAL to tmp_path to avoid cross-Python flake #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maltsev-dev wants to merge 1 commit into from
Closed

fix(tests): pin test_runtime WAL to tmp_path to avoid cross-Python flake #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/test_protect_branches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,20 @@


@pytest.fixture
def test_runtime(monkeypatch):
def test_runtime(monkeypatch, tmp_path):
"""Provide a runtime in test mode so get_runtime returns without
authenticating against a real server.

Replays any WAL left over from previous test runs in a
tmp_path-scoped WAL file so the constructor's
``_replay_from_wal`` never reads ``~/.nullrun/sdk.wal`` and
flushes real on-disk events to a live API. This avoids the
cross-Python-version flake seen on CI in 2026-07-11 where
3.11 picked up a stale WAL from a 3.10/3.12 worker that
finished without explicitly clearing it.
"""
monkeypatch.setenv("NULLRUN_API_KEY", "test-key-12345678")
monkeypatch.setenv("NULLRUN_WAL_PATH", str(tmp_path / "sdk.wal"))
NullRunRuntime.reset_instance()
rt = NullRunRuntime(api_key="test-key-12345678", _test_mode=True)
rt.organization_id = "org-1"
Expand Down
Loading