feat(docs): migrate to doc-kit#5438
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5438 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 110 110
Lines 37106 37106
=======================================
Hits 34683 34683
Misses 2423 2423 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
cc @nodejs/undici @nodejs/web-infra |
|
This is impressive, huge +1 for doc-kit!! If you are up for it, I would slightly prefer to have a system to provide the docs for the various release lines. This is why I was thinking to use the other repo. |
|
No problem! We are working on a similar pipeline for webpack, so it shouldn't be too hard. However, you should note that the previous docs don't follow doc-kit structure, so older docs might not render 100% the same as newer docs. Just to confirm, let's say I change this PR to only change the doc format to support doc-kit, and then a PR in the undici website repo to read the various tags and build a website around it? |
e3ad270 to
ef1f473
Compare
|
@mcollina in order for the site to update, on this repo's release, it needs to trigger a rebuild there, however, the |
AugustinMauroy
left a comment
There was a problem hiding this comment.
in terme of structure that seem good
|
There are conflicts now :( |
|
Rebased! |
Migrates the docs to use
doc-kitDemo: https://forked-by-avivkeller.github.io/undici/
Fixes: #3132
Fixes: #183
Fixes: #1205
Fixes: #1865
Closes: #2208