Skip to content

feat: add asdf install method#8916

Open
jhcpeixoto wants to merge 5 commits into
nodejs:mainfrom
jhcpeixoto:feat/asdf-install-method
Open

feat: add asdf install method#8916
jhcpeixoto wants to merge 5 commits into
nodejs:mainfrom
jhcpeixoto:feat/asdf-install-method

Conversation

@jhcpeixoto
Copy link
Copy Markdown

Closes #8488

Summary

  • add asdf as a community install method for macOS and Linux
  • add the English asdf download snippet
  • allow install methods without an icon so asdf can be listed without inventing unofficial branding

Verification

  • corepack pnpm exec prettier apps/site/util/download/constants.json apps/site/types/release.ts apps/site/util/download/index.tsx packages/i18n/src/locales/en.json apps/site/snippets/en/download/asdf.bash --check --ignore-unknown
  • corepack pnpm --filter @node-core/website exec node --experimental-test-module-mocks --enable-source-maps --import=global-jsdom/register --import=tsx --import=tests/setup.jsx --test util/tests/download.test.mjs
  • corepack pnpm --filter @node-core/website exec eslint util/download/index.tsx types/release.ts
  • corepack pnpm --filter @node-core/website run build:blog-data
  • corepack pnpm --filter @node-core/website run lint:types

Copilot AI review requested due to automatic review settings May 27, 2026 14:51
@jhcpeixoto jhcpeixoto requested a review from a team as a code owner May 27, 2026 14:51
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview May 27, 2026 5:23pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Download-page content and UI metadata only; no auth, data, or core runtime changes.

Overview
Adds asdf as a community install option on macOS and Linux in the download flow, with an English bash snippet that uses asdf v0.16+ (plugin add, install, set --home) and links to official getting-started docs.

Install-method dropdown icons are now optional: methods without an icon in config (asdf) get no iconImage, covered by a unit test. Types, constants.json, and English copy for the platform info blurb are updated accordingly.

Reviewed by Cursor Bugbot for commit a977017. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds asdf as a supported Node.js installation method on the download page.

Changes:

  • Adds ASDF to the InstallationMethod type and a new entry in the download platform constants (Mac/Linux).
  • Adds an asdf.bash snippet with install instructions and a localized info string in en.json.
  • Updates createIcon to gracefully handle missing icon names/components.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/site/types/release.ts Adds ASDF to the InstallationMethod union.
apps/site/util/download/constants.json Registers the new ASDF platform entry.
apps/site/util/download/index.tsx Makes createIcon tolerant of undefined/missing icons.
apps/site/snippets/en/download/asdf.bash New install snippet for asdf.
packages/i18n/src/locales/en.json Adds localized info text for asdf.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/site/snippets/en/download/asdf.bash Outdated
Comment thread apps/site/util/download/index.tsx Outdated
Comment thread apps/site/util/download/index.tsx Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.30%. Comparing base (b97f706) to head (642633b).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/site/util/download/index.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8916      +/-   ##
==========================================
+ Coverage   73.23%   73.30%   +0.06%     
==========================================
  Files         102      102              
  Lines        8628     8646      +18     
  Branches      313      314       +1     
==========================================
+ Hits         6319     6338      +19     
+ Misses       2308     2306       -2     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e318ab6. Configure here.

Comment thread apps/site/snippets/en/download/asdf.bash Outdated
@jhcpeixoto
Copy link
Copy Markdown
Author

jhcpeixoto commented May 27, 2026

Updated the asdf snippet again in 3de00f9 to use the current asdf v0.16+ syntax

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ASDF as Community option for install suggestions on download page

4 participants