feat: add asdf install method#8916
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Install-method dropdown icons are now optional: methods without an Reviewed by Cursor Bugbot for commit a977017. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds asdf as a supported Node.js installation method on the download page.
Changes:
- Adds
ASDFto theInstallationMethodtype and a new entry in the download platform constants (Mac/Linux). - Adds an
asdf.bashsnippet with install instructions and a localized info string inen.json. - Updates
createIconto gracefully handle missing icon names/components.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/site/types/release.ts | Adds ASDF to the InstallationMethod union. |
| apps/site/util/download/constants.json | Registers the new ASDF platform entry. |
| apps/site/util/download/index.tsx | Makes createIcon tolerant of undefined/missing icons. |
| apps/site/snippets/en/download/asdf.bash | New install snippet for asdf. |
| packages/i18n/src/locales/en.json | Adds localized info text for asdf. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8916 +/- ##
==========================================
+ Coverage 73.23% 73.30% +0.06%
==========================================
Files 102 102
Lines 8628 8646 +18
Branches 313 314 +1
==========================================
+ Hits 6319 6338 +19
+ Misses 2308 2306 -2
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e318ab6. Configure here.
|
Updated the asdf snippet again in 3de00f9 to use the current asdf v0.16+ syntax |

Closes #8488
Summary
Verification