Skip to content

build: add --shared-perfetto flag - #65614

Draft
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:shared-perfetto-sdk
Draft

build: add --shared-perfetto flag#65614
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:shared-perfetto-sdk

Conversation

@aduh95

@aduh95 aduh95 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Converted to draft, I need to investigate the abseil version conflict

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 485 -> 492 => +7 7 / 492 = 1.4%
aarch64-linux 486 -> 493 => +7 7 / 493 = 1.4%
x86_64-darwin 427 -> 434 => +7 7 / 434 = 1.6%
aarch64-darwin 428 -> 435 => +7 7 / 435 = 1.6%
Total 1826 -> 1854 => +28 28 / 1854 = 1.5%
Changelog
@@ -16,0 +17,8 @@
+/nix/store/zfjmy81j7shdl54pdhqfkxdiqj0k8w6f-abseil-cpp-20260107.1 (aarch64-darwin)
+/nix/store/98crzsncq5khm9cyckslmd2xz8y536va-abseil-cpp-20260107.1 (aarch64-linux)
+/nix/store/g5bfb54qhcprz6fbwy6y0344gyhdq39n-abseil-cpp-20260107.1 (x86_64-darwin)
+/nix/store/vp4ha3gygz1cm6f7qgrrysyyk1nzfgps-abseil-cpp-20260107.1 (x86_64-linux)
+/nix/store/mcbznvdb0xcncmv55gkg8gvyjjasn46k-abseil-cpp-20260107.1-dev (aarch64-darwin)
+/nix/store/wi8nissjz9mxlzk8v8sqa705h5f4qhb6-abseil-cpp-20260107.1-dev (aarch64-linux)
+/nix/store/s84wwacmp88nld1znzjkrn3s0gsg930c-abseil-cpp-20260107.1-dev (x86_64-darwin)
+/nix/store/yf9f11zq3w5da045klvrpvqawh19sz6m-abseil-cpp-20260107.1-dev (x86_64-linux)
@@ -1286,0 +1295,8 @@
+/nix/store/k2mhbhp50ha9sh1nq7zx1hz7pg4fkvgi-perfetto-sdk-58.2 (aarch64-darwin)
+/nix/store/6304s9p1z8g8z30k6dzzkwqxrx5vh95c-perfetto-sdk-58.2 (aarch64-linux)
+/nix/store/sy3bgw5f9g8g0zwbxns3qknab5ncb8y9-perfetto-sdk-58.2 (x86_64-darwin)
+/nix/store/kh3yz4yv8k258233v6yqjhn6k0hc1hgb-perfetto-sdk-58.2 (x86_64-linux)
+/nix/store/5414nddd7pb9sb2plssci3373cpjkv5y-perfetto-sdk-58.2-dev (aarch64-darwin)
+/nix/store/1mivibsxj1qbpkp9xwas8gmakqvnavda-perfetto-sdk-58.2-dev (aarch64-linux)
+/nix/store/b74ljrh1z52l01636wblrlgxhajir4ik-perfetto-sdk-58.2-dev (x86_64-darwin)
+/nix/store/y4vswj1xzybq5n8nm2f44rqaxkp0jick-perfetto-sdk-58.2-dev (x86_64-linux)
@@ -1479,0 +1496,4 @@
+/nix/store/dmcp8nf832l2fbhhbac84bq4prrlk1nq-protobuf-34.1 (x86_64-darwin)
+/nix/store/v7ijrik242ylbl098071amfs9wzks07i-protobuf-35.1 (aarch64-darwin)
+/nix/store/hca15dahd4s61nvwambv9150d7law0k4-protobuf-35.1 (aarch64-linux)
+/nix/store/8xvlgqcpasv0jzfc5v850g8nlaka4by0-protobuf-35.1 (x86_64-linux)
@@ -1573,0 +1594,8 @@
+/nix/store/ap7yijpbkljh87ihmvf30vm8j3hqf03k-re2-2025-11-05 (aarch64-darwin)
+/nix/store/v4wjmz1in47dxgsyzy7lrspywcrz0g9a-re2-2025-11-05 (aarch64-linux)
+/nix/store/fh849rr6slz7d44xdbi1556ama6g5hvm-re2-2025-11-05 (x86_64-darwin)
+/nix/store/xjam1mxyx2yksq3bhizb5b850jcwaag4-re2-2025-11-05 (x86_64-linux)
+/nix/store/aq68al96mapmv83r9621vdjlc38v971z-re2-2025-11-05-dev (aarch64-darwin)
+/nix/store/11qmzhf83syb6l86z398xac2x92p46lz-re2-2025-11-05-dev (aarch64-linux)
+/nix/store/dvzkr8dc8m5lmr4vvkpga60bzgwacq2f-re2-2025-11-05-dev (x86_64-darwin)
+/nix/store/8pvgqvnw846ajsk2mx9xwlx0cv2bir1p-re2-2025-11-05-dev (x86_64-linux)

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (2743045) to head (ac1e1e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65614      +/-   ##
==========================================
- Coverage   90.06%   90.04%   -0.02%     
==========================================
  Files         751      751              
  Lines      254917   254917              
  Branches    48133    48125       -8     
==========================================
- Hits       229580   229552      -28     
- Misses      16493    16532      +39     
+ Partials     8844     8833      -11     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95 marked this pull request as draft August 28, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants