Skip to content

tools: update c-ares updater script#64194

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:c-ares-auto-updater
Open

tools: update c-ares updater script#64194
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:c-ares-auto-updater

Conversation

@aduh95

@aduh95 aduh95 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fixes the version comparison (the current version tries to create a PR every week because v1.34.6 and 1.34.6 are not the same string), adds signature verification, removes top-level cd and makes the output more debuggable.

Here's the script I've used to generate the kbx file:

GNUPGHOME=$(mktemp -d)
GNUPGHOME="$GNUPGHOME" gpg --keyserver keyserver.ubuntu.com --recv-keys 27EDEAF22F3ABCEB50DB9A125CC908FDB71E12C2
GNUPGHOME="$GNUPGHOME" gpg --keyserver keyserver.ubuntu.com --recv-keys DA7D64E4C82C6294CB73A20E22E3D13B5411B7CA
mv "$GNUPGHOME/pubring.kbx" tools/dep_updaters/c-ares.kbx

@aduh95
tools: update c-ares updater script
018052b 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 29, 2026
@aduh95 aduh95 mentioned this pull request Jun 29, 2026
Closed
@aduh95 aduh95 requested a review from Renegade334 June 29, 2026 10:06
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes
@Renegade334 Renegade334 Awaiting requested review from Renegade334

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @joyeecheung @richardlau