tty: add raw-vt and io raw modes#64140
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
4 tasks
samuel-williams-shopify
force-pushed
the
tty-raw-vt-io-mode
branch
3 times, most recently
from
c2211c4 to
f8d0128
Compare
samuel-williams-shopify
force-pushed
the
tty-raw-vt-io-mode
branch
from
f8d0128 to
5831aec
Compare
addaleax
reviewed
Jun 29, 2026
| raw device. If `false`, configures the `tty.ReadStream` to operate in its | ||
| default mode. The `readStream.isRaw` property will be set to the resulting | ||
| mode. | ||
| * `mode` {boolean|string} If `true` or `'raw-vt'`, configures the |
Member
There was a problem hiding this comment.
I would not use 'raw-vt' as a name and instead just use 'raw'. UV_TTY_MODE_RAW_VT is what UV_TTY_MODE_RAW should probably have been all along – the only reason they aren't merged (yet) into a single constant is backwards compatibility expectations in libuv.
| ttyMode = UV_TTY_MODE_IO; | ||
| } else if (rawMode === 'raw-vt') { | ||
| ttyMode = UV_TTY_MODE_RAW_VT; | ||
| } |
Member
There was a problem hiding this comment.
Should we reject invalid/unrecognized values here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds string raw-mode selection to
tty.ReadStream#setRawMode():setRawMode(true)keeps the existing behavior.setRawMode('raw-vt')explicitly selects the existing Node raw mode backed by libuvUV_TTY_MODE_RAW_VT.setRawMode('io')selects libuvUV_TTY_MODE_IOfor binary-safe I/O mode on Unix.readStream.rawModeexposes the exact current mode whilereadStream.isRawremains boolean for compatibility.This is intended to address the output-processing distinction discussed in #63059 and follows libuv's existing
UV_TTY_MODE_IOsemantics. It preserves the currentsetRawMode(true)behavior instead of changing it.Refs: #63059
Refs: libuv/libuv#32
Local verification:
git diff --checkpasses.build-script-buildexecutables as untrusted on this machine; relying on CI for the native build and pseudo-tty test run.