build: add manually-dispatched stress-test workflow#64118
Conversation
|
Review requested:
|
a929666 to
1a81765
Compare
|
How would I trigger this on a PR created from the contributor's fork? |
This version only allows triggering from a branch in the repo the workflow file is in - you could still do it from a PR, just that PR must come from a branch here (which also means you need to have write access here). If someone wants to make it work for a fork I think that can be a follow up, but be aware that allowing runs from forks can carry security risks, and to make this action useful there's an argument that allows arbitrary arguments to I think for the best balance between usefulness v.s. safety it's better to only allow people with write access in this repo to test from a branch in this repo. If they want to run it from a fork, just use an action from that fork, but not from this repo. So to your question - pull that contributor's branch to your fork, and run that action from your fork. |
I only asked because of the description that specifically mentions PRs. I'm fine with the scope-as is. |
|
PRs are still possible, just that the PRs need to come from a branch in repo, not from a fork e.g. the PR must be |
Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1a81765 to
3c12ff7
Compare
|
Fixed the linter complaints. Can you take a look again? Thanks! @panva @Renegade334 |
| CC: ${{ startsWith(inputs.os, 'ubuntu') && 'sccache clang-19' || 'sccache gcc' }} | ||
| CXX: ${{ startsWith(inputs.os, 'ubuntu') && 'sccache clang++-19' || 'sccache g++' }} |
There was a problem hiding this comment.
Don't think that there's any need to cache locally on the runner if there's only one build per workflow run?
| CC: ${{ startsWith(inputs.os, 'ubuntu') && 'sccache clang-19' || 'sccache gcc' }} | |
| CXX: ${{ startsWith(inputs.os, 'ubuntu') && 'sccache clang++-19' || 'sccache g++' }} | |
| CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} ${{ startsWith(inputs.os, 'ubuntu') && 'clang-19' || 'gcc' }} | |
| CXX: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} ${{ startsWith(inputs.os, 'ubuntu') && 'clang++-19' || 'g++' }} |
| run: | | ||
| rustup override set "$RUSTC_VERSION" | ||
| rustup --version | ||
| - name: Set up sccache |
There was a problem hiding this comment.
| - name: Set up sccache | |
| - name: Set up sccache | |
| if: github.base_ref == 'main' || github.ref_name == 'main' |
Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness.