Skip to content

tools: add GHA benchmark runner#60293

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:benchmark-gha
Jun 29, 2026
Merged

tools: add GHA benchmark runner#60293
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:benchmark-gha

Conversation

@aduh95

@aduh95 aduh95 commented Oct 17, 2025

Copy link
Copy Markdown
Contributor
  • it allows non-collaborators can run them on their forks.
  • testing on different arch gives more relevant results.
  • if folks want to run benchmarks on their own machine, I find it helpful to have a GHA workflow to copy to understand how to set it up.

Example of benchmark workflow: https://github.com/aduh95/node/actions/runs/26591497321

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 17, 2025
@targos

targos commented Oct 17, 2025

Copy link
Copy Markdown
Member

I would not be very confident running benchmarks on Cloud VMs that we don't know much about. That's why we have dedicated bare metal machines for that in CI.

@aduh95

aduh95 commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

I would not be very confident running benchmarks on Cloud VMs that we don't know much about. That's why we have dedicated bare metal machines for that in CI.

Do you think we should add a comment about that in the output? This probably goes without saying, but I'm not suggesting we get rid of the bare metal machines, I'm suggesting that as an addition.

@targos

targos commented Oct 17, 2025

Copy link
Copy Markdown
Member

Maybe. Something that says only the results of the Jenkins benchmark CI can be used make a decision.

@aduh95 aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 26, 2025
@aduh95

aduh95 commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

One upside of having something like that: it allows one to validate changes to the Benchmark tooling during a CI lockdown

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd find this very useful. But if possible extract the shared bits to a composite action and have it be it's own dispatchable workflow, not test-shared.yml

@aduh95 aduh95 force-pushed the benchmark-gha branch 2 times, most recently from 1824dba to e5686ff Compare May 28, 2026 17:06
@panva panva changed the title tools: add benchmark runner to test-shared tools: add GHA benchmark runner May 28, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9ad22d1 into nodejs:main Jun 29, 2026
32 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 9ad22d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants