Clang + libstdc++ binaries to use rpath#632
Merged
Merged
Conversation
Binaries built with clang + libstdc++ from brew GCC didn't actually use same libstdc++ at runtime. Instead, they used system provided libstdc++. This change adds an rpath linker command to instruct ldd to load libstdc++.so.6 from the same brew GCC library dir that is used during linking.
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures CI-built binaries that are compiled with Clang but linked against Homebrew GCC’s libstdc++ use the intended Homebrew-provided runtime library by adding an rpath to the link flags.
Changes:
- Add
-Wl,-rpath,<brew gcc libdir>to the preset linker flags used for Clang + libstdc++ builds. - Apply the same rpath addition for both executable and shared-library linker flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binaries built with clang + libstdc++ from brew GCC didn't actually use same libstdc++ at runtime. Instead, they used system provided libstdc++. This change adds an rpath linker command to instruct ldd to load libstdc++.so.6 from the same brew GCC library dir that is used during linking.