Allow setting enrich_login_id_token_with_userinfo per-provider in the UI#1444
Closed
s3n-w6i wants to merge 15 commits into
Closed
Allow setting enrich_login_id_token_with_userinfo per-provider in the UI#1444s3n-w6i wants to merge 15 commits into
enrich_login_id_token_with_userinfo per-provider in the UI#1444s3n-w6i wants to merge 15 commits into
Conversation
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
This reverts commit 7fcb03d. Signed-off-by: Spitap <dev@asdrip.fr>
Signed-off-by: Spitap <dev@asdrip.fr>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Fixed Disable Other Login Methods command. Missed a / Signed-off-by: JATippit <11259172+JATippit@users.noreply.github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.0...v3.1.2) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [phpseclib/phpseclib](https://github.com/phpseclib/phpseclib) from 2.0.53 to 2.0.54. - [Release notes](https://github.com/phpseclib/phpseclib/releases) - [Changelog](https://github.com/phpseclib/phpseclib/blob/master/CHANGELOG.md) - [Commits](phpseclib/phpseclib@2.0.53...2.0.54) --- updated-dependencies: - dependency-name: phpseclib/phpseclib dependency-version: 2.0.54 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.6 to 8.5.13. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.6...8.5.13) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [symfony/event-dispatcher](https://github.com/symfony/event-dispatcher) from 7.4.8 to 7.4.9. - [Release notes](https://github.com/symfony/event-dispatcher/releases) - [Changelog](https://github.com/symfony/event-dispatcher/blob/8.1/CHANGELOG.md) - [Commits](symfony/event-dispatcher@v7.4.8...v7.4.9) --- updated-dependencies: - dependency-name: symfony/event-dispatcher dependency-version: 7.4.9 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
s3n-w6i
force-pushed
the
feat/per_provider_enrich_userinfo
branch
from
81eb7d4 to
3160bb8
Compare
Contributor
Author
|
Closing to rework this on another branch with proper sign-off commits |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change introduces a checkbox into the provider settings that allows enabling the existing
enrich_login_id_token_with_userinfooption on a per-provider basis.To be backwards compatible, if the global
enrich_login_id_token_with_userinfois set to true, the userinfo endpoint is still fetched for all providers, regardless of their per-provider setting.Why
Open questions
enrichLoginIdTokenWithUserinfoon the provider's settings object. This does not require any database schema changes, right?