Skip to content

Fix Embed table full scroll #2744

Open
taiebot wants to merge 1 commit into
nextcloud:mainfrom
taiebot:Embed-scroll-all
Open

Fix Embed table full scroll #2744
taiebot wants to merge 1 commit into
nextcloud:mainfrom
taiebot:Embed-scroll-all

Conversation

@taiebot

@taiebot taiebot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
  • Fix remove sticky and scroll everything

Widget is too small to let headers stick so let headers scroll, this as well solves issue with overlay on the headers by simplifying the logic. The only issue is the three dots on the right but they are accessible if the user goes back to the top of the table


🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

* Fix remove sticky and scroll everything 

Widget is small so let the user scroll 

Signed-off-by: taiebot <dedreuil@yahoo.fr>

* Fix comment

Signed-off-by: taiebot <dedreuil@yahoo.fr>

---------

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@taiebot taiebot requested review from blizzz and enjeck as code owners June 17, 2026 21:10

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "after" screenshot, I don't see the title?

@taiebot

taiebot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

It's by design. The widget is so small that it does not make sense to keep the headers in view. I can only see one row by moving up the headers. With this design decision i can see more rows (3) . As long as the widget is not increased in size i would recommend this solution. This is simpler as well with overlay behaviour inside the widget.

image

You can test the feeling by putting in the dev console this code when an embeddded table is loadded => for designers to see. It is not at all off putting and look more natural with such a small view.

document.querySelector('.tables-content-widget .header').style.zIndex = 10;
document.querySelector('.tables-content-widget .header').style.position = 'relative';

document.querySelectorAll('.tables-content-widget thead').forEach(el => {
  el.style.position = 'static';
  el.style.zIndex = 5;
});

@enjeck

enjeck commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Not sure how to reproduce the issue since without these changes, it renders for me well. Here, I'm embedding within Notes:

Screenshot 2026-06-20 at 07 36 47

Plus, the before and after are of different tables, so doesn't appropriately reflect the fix. I also don't agree with removing the header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants