Fix respect view column order in public sharing#2701
Conversation
enjeck
left a comment
There was a problem hiding this comment.
Look good, except for the linting errors. Can be fixed by running npm run lint:fix
|
Also, need to sign commits to fix DCO: https://github.com/nextcloud/tables/pull/2701/checks?check_run_id=81362784234 |
Signed-off-by: taiebot <dedreuil@yahoo.fr>
|
hmm, seems like we still need to run |
Signed-off-by: taiebot <dedreuil@yahoo.fr>
weird how it's still failing 🤔 |
Had to force the indentation by resetting everything to zero. Looks like it is working now. I had some errors yesterday but did not think of doing this Signed-off-by: taiebot <dedreuil@yahoo.fr>
|
Hopefully all good now. Sorry not used to those CI shenanigans |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
At the moment filtered views are not sorted as per the view column order if you share them pubicly
with this PR they are sorted and respect the table order. this will fix #2595
Screenshot of private view

in public sorted

with an other order.
