fix: Tapping an item in list widget should open the tapped note - #3312
Open
nkming2 wants to merge 1 commit into
Open
fix: Tapping an item in list widget should open the tapped note#3312nkming2 wants to merge 1 commit into
nkming2 wants to merge 1 commit into
Conversation
Marking the pending intent as immutable will prevent the system to fill in the data later. It will then open an empty note as the note id is empty
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when tapping an item in the list widget, the app will open an empty note instead of the tapped note. This has been reported in multiple issues like: #3168 #2790
The reason behind this is that the pending intent template is marked as immutable. This make it impossible for the system to fill in the data later. It will then open an empty note as the note id is passed to the editor as empty.
This PR added the mutable flag to the pending intent.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)