Pull iOS stringdicts with default source#956
Merged
Merged
Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Member
|
Good idea. Documenation of used option is very poor. |
Member
|
Also need to push before? |
Contributor
Author
No, sources are pushed only once, at start. Then we pull all, but then pull again which replaces the "bad" stringdicts with the new ones which include source if untranslated. This resolves strings not being displayed at all: 
No need to push, as this is only needed for clients. Pushing this to Transifex might screw up translations. |
mpivchev
requested review from
Ivansss,
SystemKeeper,
i2h3,
marinofaggiana and
tobiasKaminsky
Contributor
Author
|
@Ivansss @SystemKeeper if this works fine we can do the same with Talk iOS |
Member
|
I cannot review as I am not using the tool myself. |
tobiasKaminsky
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled .stringdicts (containing singular/plural variations of sentences) from Transifex do not include a default string if not translated, resulting in no text being displayed at all on iOS. This resolves this by pulling the source (English) if a string is not translated.
🤖 AI (if applicable)