Skip to content

Feature/visual room browser v4 - #8731

Merged
odzhychko merged 1 commit into
mainfrom
feature/visual-room-browser-v4
Aug 25, 2026
Merged

Feature/visual room browser v4#8731
odzhychko merged 1 commit into
mainfrom
feature/visual-room-browser-v4

Conversation

@odzhychko

@odzhychko odzhychko commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Cleaned up version of #8264
Resolves #8724

Before (main)

image

After

Screencast.From.2026-08-15.20-01-26.mp4

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.18321% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/models/resourceProps.ts 44.44% 4 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@odzhychko
odzhychko force-pushed the feature/visual-room-browser-v4 branch 2 times, most recently from 48a1ed8 to 6bbba7a Compare August 15, 2026 17:59
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Aug 15, 2026
@odzhychko odzhychko self-assigned this Aug 15, 2026
@odzhychko
odzhychko marked this pull request as ready for review August 15, 2026 18:07
@odzhychko

Copy link
Copy Markdown
Contributor Author

@SebastianKrupinski Let me know if you find something with regards to code organization.
@nimishavijay Let me know if you find something with regards to UI/UX.

@SebastianKrupinski SebastianKrupinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I tested this this works kind of:

Image

As mentioned already all the fancy spiting and join does not really work and only works for "Netherlands" style address format.

Comment thread src/utils/roomFilter.ts Outdated
Comment thread src/utils/roomFilter.ts Outdated
Comment thread src/utils/roomFilter.ts Outdated
@odzhychko

Copy link
Copy Markdown
Contributor Author

Okay I tested this this works kind of:

Your screenshot looks of. Should look like in the description have you checked out feature/visual-room-browser-v4 (-v4)?

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Okay I tested this this works kind of:

Your screenshot looks of. Should look like in the description have you checked out feature/visual-room-browser-v4 (-v4)?

Yeah, I think so... but here is another take

image

@odzhychko

Copy link
Copy Markdown
Contributor Author

Okay I tested this this works kind of:

Your screenshot looks of. Should look like in the description have you checked out feature/visual-room-browser-v4 (-v4)?

Yeah, I think so... but here is another take

Looks still wrong...

image

Seating capacity should be indicate In the bottom left and not top right.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Hey,

Retested this again last night... Found two minor issues...

a) when there are no rooms, we should hide all the search functions

image

b) I have 2 buildings with floor 1... but they are combined in this drop down in to a single floor... since we now have a building name... maybe display the building name and the floor?

Screenshot 2026-08-21 090102

@odzhychko

Copy link
Copy Markdown
Contributor Author

a) when there are no rooms, we should hide all the search functions

Fixed. The button is now hidden, if no rooms are available.

image

@odzhychko

Copy link
Copy Markdown
Contributor Author

b) I have 2 buildings with floor 1... but they are combined in this drop down in to a single floor... since we now have a building name... maybe display the building name and the floor?

  1. Seems you haven't tested with the changes Feat/add room building name property calendar_resource_management#302 . Because then you would see a filter for "Building".
image
  1. As we have a filter for building (if building names are provided by the resource provider), a filter for floors that includes the building seems odd. So I'd like to leave it as is.

@odzhychko odzhychko added this to the v6.6.0 milestone Aug 24, 2026
@odzhychko
odzhychko enabled auto-merge August 24, 2026 18:18
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

b) I have 2 buildings with floor 1... but they are combined in this drop down in to a single floor... since we now have a building name... maybe display the building name and the floor?

1. Seems you haven't tested with the changes [Feat/add room building name property calendar_resource_management#302](https://github.com/nextcloud/calendar_resource_management/pull/302) . Because then you would see a filter for "Building".

My bad, I did pull the latest version but forgot to run npm ci

image

Much better now

Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@SebastianKrupinski
SebastianKrupinski force-pushed the feature/visual-room-browser-v4 branch from 7c5b2bb to e8641cd Compare August 25, 2026 02:01
@odzhychko
odzhychko merged commit 0c04ea8 into main Aug 25, 2026
41 checks passed
@odzhychko
odzhychko deleted the feature/visual-room-browser-v4 branch August 25, 2026 02:05
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Aug 25, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Lol. I guess you had auto merge turned on. Cause I just squashed and re-based it for you and it now merged on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

[Enhancement] Allow Rooms and Resources dropdown to display all options on click/focus without requiring text input

2 participants