configure.ac: revise NUT_ARG* methods to remember if the option was "given" by caller or defaulted - #3577
Open
jimklimov wants to merge 26 commits into
Open
configure.ac: revise NUT_ARG* methods to remember if the option was "given" by caller or defaulted#3577jimklimov wants to merge 26 commits into
configure.ac: revise NUT_ARG* methods to remember if the option was "given" by caller or defaulted#3577jimklimov wants to merge 26 commits into
Conversation
…to remember nut_withGiven_*/nut_enableGiven_* status of the option, and fix passing one default and one custom user/name value [networkupstools#3513, networkupstools#3140] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
bug
packaging
CI
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 7b9831c is temporarily available: NUT-tarballs-PR-3577.zip. |
…ith fatal warnings (auto level) and GCC toolkits" filter does not actually select Strict-C - be more explicit about this in code/comments [networkupstools#3567] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.5086-master completed (commit 8e93243d98 by @jimklimov)
|
|
✅ Build nut 2.8.5.5087-master completed (commit 2bd7292830 by @jimklimov)
|
…OLS_REQUIRE_TWEAK definition as a nested collection [networkupstools#3567] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.5088-master failed (commit 027750de00 by @jimklimov) |
Pass at least GCC builds Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ded - bring it back [networkupstools#3567] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.5089-master completed (commit d1fbe72f70 by @jimklimov)
|
|
✅ Build nut 2.8.5.5089-master completed (commit d1fbe72f70 by @jimklimov) |
Member
Author
|
Faults with GCC Strict-C89 builds (recently re-enabled) on newer platforms (OmniOS latest, Fedora 43) are due to bad NSS headers, fix proposed in https://bugzilla.mozilla.org/show_bug.cgi?id=2064644 and mozilla/nss#34 (auto-closed by bot) and will be applied locally on those agents. |
… FAILED scenarios (configure, *clean) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.5090-master completed (commit c6162ae488 by @jimklimov)
|
…ized to avoid teardown when we never initialized NSS (this causes the library to use some memory and fail memcheck) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…kupstools#3329] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s vs autotools semantics Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…trdup() cleanup [networkupstools#3329] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ck-NIT{-sandbox,}{-devel,}` attempts
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… of what we allocated [networkupstools#3329] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ck/download debuginfo files) Thanks to https://bbs.archlinux.org/viewtopic.php?id=279297 for the hints. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…kupstools#3329] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…slog_setproctag() [networkupstools#3379] The setproctag() behind it makes a copy already, so the callers may free() theirs if they like. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…and secondary logformat_allocated Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… cleanup Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…r already Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.5091-master failed (commit 9c87fb0e01 by @jimklimov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and fix passing one default and one custom user/name value
Closes: #3513
Follow-up to #3567 in refining the CI recipes.
Fallout of #3140 (NUT v2.8.5): In that PR, the logic was changed to track if the caller gave us the user and group values - and then should have specified both. That check was flawed in case that (exactly) one of those specified values was same as the default that the
configurescript would apply, then it got treated as not-set and rejected the build configuration.