Skip to content

select: computed: Handle overconstrained left/right relative position #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlsa merged 1 commit into from
Jul 26, 2026
Merged

select: computed: Handle overconstrained left/right relative position #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions src/select/computed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,18 @@ uint8_t css_computed_right(const css_computed_style *style,
&left_length,
&left_unit);

if (right == CSS_RIGHT_AUTO) {
if (right == CSS_RIGHT_SET) {
if (left == CSS_LEFT_SET) {
/* Over-constrained; both right and left set */
uint8_t direction = get_direction(style);

if (direction == CSS_DIRECTION_LTR) {
/* Left wins -> -left */
*length = -left_length;
*unit = left_unit;
}
}
} else {
if (left == CSS_LEFT_SET) {
/* Right is auto => -left */
*length = -left_length;
Expand All @@ -532,12 +543,9 @@ uint8_t css_computed_right(const css_computed_style *style,
*length = 0;
*unit = CSS_UNIT_PX;
}
} else {
/** \todo Consider containing block's direction
* if overconstrained */
}

right = CSS_RIGHT_SET;
right = CSS_RIGHT_SET;
}
}

return right;
Expand Down Expand Up @@ -601,7 +609,18 @@ uint8_t css_computed_left(const css_computed_style *style,
&right_length,
&right_unit);

if (left == CSS_LEFT_AUTO) {
if (left == CSS_LEFT_SET) {
if (right == CSS_RIGHT_SET) {
/* Over-constrained; both left and right set */
uint8_t direction = get_direction(style);

if (direction == CSS_DIRECTION_RTL) {
/* Right wins -> -right */
*length = -right_length;
*unit = right_unit;
}
}
} else {
if (right == CSS_RIGHT_SET) {
/* Left is auto => -right */
*length = -right_length;
Expand All @@ -611,12 +630,9 @@ uint8_t css_computed_left(const css_computed_style *style,
*length = 0;
*unit = CSS_UNIT_PX;
}
} else {
/** \todo Consider containing block's direction
* if overconstrained */
}

left = CSS_LEFT_SET;
left = CSS_LEFT_SET;
}
}

return left;
Expand Down
Loading