Fixes #649: Refresh query_counts.json baseline for current NetBox main - #650
Fixes #649: Refresh query_counts.json baseline for current NetBox main#650bctiemann wants to merge 1 commit into
Conversation
tests (main) was failing on 4 list-view query-count assertions, expecting 2 more queries than NetBox's current main branch actually issues -- an upstream prefetch/permission-check optimization shaved 2 queries off customobject-simple, customobject-objectfields, customobject-complex, and customobjecttype's list_objects_with_permission checks since these baselines were last recorded. Regenerated via UPDATE_QUERY_COUNTS=1 against a clean checkout of NetBox main (not the locally cached checkout, which was 33 commits behind and had a handful of divergent dependency pins). All four keys dropped by exactly 2 queries each, matching the CI failure precisely; no other keys changed. Re-ran the full plugin suite (1126 tests) against the same environment to confirm nothing else regressed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Heads up on CI: Root cause: NetBox core commit This isn't fixable from this repo — it resolves itself once NetBox core's |
Summary
tests (main)CI leg was failing on 4list_objects_with_permissionquery-count assertions, expecting 2 more queries than NetBox's currentmainbranch actually issues for those views. Confirmed this is pre-existing drift, not caused by any specific PR: it reproduces identically on an unmodifiednetbox-custom-objectsmain(see run 31199832224) — an upstream query-count optimization onnetbox-community/netboxmainshaved 2 queries off these checks since the baselines were last recorded.netbox_custom_objects/tests/query_counts.jsonviaUPDATE_QUERY_COUNTS=1, run against a clean worktree of NetBox's actualmaintip (not a locally cached/stale checkout) to match what CI fetches.customobject-simple,customobject-objectfields,customobject-complex,customobjecttype) dropped by exactly 2 queries each — matching the CI failure precisely. No other baseline keys changed.Test plan
python netbox/manage.py test netbox_custom_objects.tests.test_viewspasses against current NetBoxmainwith the refreshed baseline.ruff checkclean.Closes: #649
🤖 Generated with Claude Code