jruby extension#30
Open
kares wants to merge 5 commits into
Open
Conversation
generated based on C sources
headius
reviewed
Jun 3, 2026
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Looks good to me overall. Will be worth running some benchmarks to clean up excess allocation. A few minor review comments should be addressed.
| import java.util.Arrays; | ||
|
|
||
| public final class BCryptPbkdf { | ||
| private static final int BLF_N = 16; |
There was a problem hiding this comment.
Fix indentation to match Java standard, otherwise this will be a constant maintenance headache.
| engine.getSingletonClass().defineAnnotatedMethods(BCryptPbkdfExt.class); | ||
| } | ||
|
|
||
| @JRubyMethod(required = 4, rest = true) |
There was a problem hiding this comment.
These don't appear to be rest-arg methods so remove rest = true.
Author
There was a problem hiding this comment.
unfortunately, failing when rest = true is removed
| } | ||
|
|
||
|
|
||
| @JRubyMethod(required = 2, rest = true) |
There was a problem hiding this comment.
Remove rest = true and use two explicit arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a Java implementation (LLM generated based on current C sources)
the rest is plumbing for the JRuby extension ->
-javavariant of the gem