Clarify Partition field in Slurm Composer documentation#1333
Conversation
Updated the Partition field description to specify node options as 'genoa' and 'milan', and added a link for more information about the nodes. Signed-off-by: Geoffrey Weal <geoffrey.weal@gmail.com>
|
Test deployment successful!! (2026-07-13T04:42:17Z) See all deployed demo sites |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Ahoy! This patch updates the Slurm Composer documentation to use proper lowercase code blocks for the genoa and milan partitions, and adds a link to the compute nodes hardware details. However, ye made a rookie mistake by anchorin' yer link on the lazy words 'See here', which violates our sacred style guide. Ye've been given a fine suggestion to use descriptive text instead, lest ye want to walk the plank!
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | ----- | ------------ | ------------ | | ||
| | **Project** | The project code your usage is charged to. Only projects you belong to are listed. | `--account` | | ||
| | **Partition** | The type of node to run on. Choose **any** if you have no preference. Options are either Genoa or Milan | `--partition` | | ||
| | **Partition** | The type of node to run on. Choose **any** if you have no preference. Options are either `genoa` or `milan`. [See here for more information about the nodes that make up these partitions](../../../Batch_Computing/Hardware.md#compute-nodes). | `--partition` | |
There was a problem hiding this comment.
Avast, ye scallywag! Ye be linkin' with 'See here', which is as clear as a muddy swamp. The ship's log (our style guide) explicitly warns against anchorin' links on such ambiguous words. Ye should be linkin' to descriptive words instead, lest ye want to walk the plank!
| | **Partition** | The type of node to run on. Choose **any** if you have no preference. Options are either `genoa` or `milan`. [See here for more information about the nodes that make up these partitions](../../../Batch_Computing/Hardware.md#compute-nodes). | `--partition` | | |
| | **Partition** | The type of node to run on. Choose **any** if you have no preference. Options are either `genoa` or `milan` (see the [compute node hardware details](../../../Batch_Computing/Hardware.md#compute-nodes)). | `--partition` | |
References
- Avoid putting links on ambiguous words like 'here' or 'see here'. Use descriptive text for links. (link)
1 participant
Updated the Partition field description to specify node options as 'genoa' and 'milan', and added a link for more information about the nodes.