Conversation
|
Test deployment successful!! (2026-07-13T03:31:25Z) |
There was a problem hiding this comment.
Code Review
Ahoy, matey! This fine patch of yours moves the check for the 'public' directory up to the crow's nest and sets sail to audit every page from the built sitemap when no URL is provided. However, ye be blindly plunderin' public/sitemap.xml without checkin' if the map actually exists! Since ye set pipefail at the top of yer scroll, if that file be missin', yer whole vessel will scuttle itself into Davy Jones' locker. Best patch that leak before ye set sail!
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| else | ||
| # No URL given: audit every page from the built sitemap. | ||
| URLS="$(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \ | ||
| | sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")" | ||
| fi |
There was a problem hiding this comment.
Ahoy! Ye be blindly plunderin' public/sitemap.xml without so much as a glance to see if the map actually exists in yer 'public' port! Since ye set pipefail at the top of yer scroll, if that file be missin', yer whole vessel will scuttle itself with a nasty error. Best check if the sitemap exists first, ye scurvy dog, or suffer the wrath of the deep!
| else | |
| # No URL given: audit every page from the built sitemap. | |
| URLS="$(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \ | |
| | sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")" | |
| fi | |
| else | |
| # No URL given: audit every page from the built sitemap. | |
| if [ ! -f "public/sitemap.xml" ]; then | |
| echo "Error: 'public/sitemap.xml' does not exist. Run a build first!" >&2 | |
| exit 1 | |
| fi | |
| URLS=" | |
| $(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \ | |
| | sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")" | |
| fi |
|
Test deployment successful!! (2026-07-13T04:24:37Z) |
|
Test deployment successful!! (2026-07-13T04:52:12Z) See all deployed demo sites |
AccessLint audit — 4 URLs14 violations across 4 URLs: 🟧 14 serious. https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/No violations at the configured threshold (37 below threshold filtered). https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/CONTRIBUTING/1 violation: 🟧 1 serious (+44 below threshold). Unmapped (no source location) — 1 violation (1 serious)
https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/Software/Available_Applications/AlphaFold/12 violations: 🟧 12 serious (+61 below threshold). Unmapped (no source location) — 12 violations (12 serious)
https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/Software/Available_Applications/Dorado/1 violation: 🟧 1 serious (+43 below threshold). Unmapped (no source location) — 1 violation (1 serious)
Generated 2026-07-13T04:52:31.635Z · run log · |
No description provided.