Skip to content

Accessibility audit backlog#1332

Draft
jen-reeve wants to merge 3 commits into
mainfrom
audit-fix
Draft

Accessibility audit backlog#1332
jen-reeve wants to merge 3 commits into
mainfrom
audit-fix

Conversation

@jen-reeve

Copy link
Copy Markdown
Collaborator

No description provided.

@jen-reeve jen-reeve self-assigned this Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Test deployment successful!! (2026-07-13T03:31:25Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix

See all deployed demo sites

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Ahoy, matey! This fine patch of yours moves the check for the 'public' directory up to the crow's nest and sets sail to audit every page from the built sitemap when no URL is provided. However, ye be blindly plunderin' public/sitemap.xml without checkin' if the map actually exists! Since ye set pipefail at the top of yer scroll, if that file be missin', yer whole vessel will scuttle itself into Davy Jones' locker. Best patch that leak before ye set sail!

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread checks/run_a11y_check.sh
Comment on lines +15 to +19
else
# No URL given: audit every page from the built sitemap.
URLS="$(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \
| sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")"
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Ahoy! Ye be blindly plunderin' public/sitemap.xml without so much as a glance to see if the map actually exists in yer 'public' port! Since ye set pipefail at the top of yer scroll, if that file be missin', yer whole vessel will scuttle itself with a nasty error. Best check if the sitemap exists first, ye scurvy dog, or suffer the wrath of the deep!

Suggested change
else
# No URL given: audit every page from the built sitemap.
URLS="$(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \
| sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")"
fi
else
# No URL given: audit every page from the built sitemap.
if [ ! -f "public/sitemap.xml" ]; then
echo "Error: 'public/sitemap.xml' does not exist. Run a build first!" >&2
exit 1
fi
URLS="
$(sed -n 's#.*<loc>\(.*\)</loc>.*#\1#p' public/sitemap.xml \
| sed "s#^https\?://[^/]*/#http://localhost:${PORT}/#")"
fi

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Test deployment successful!! (2026-07-13T04:24:37Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix

See all deployed demo sites

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Test deployment successful!! (2026-07-13T04:52:12Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix

Seems the following pages differ;



See all deployed demo sites

@github-actions

Copy link
Copy Markdown
Contributor

AccessLint audit — 4 URLs

14 violations across 4 URLs: 🟧 14 serious.

https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/

No violations at the configured threshold (37 below threshold filtered).

https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/CONTRIBUTING/

1 violation: 🟧 1 serious (+44 below threshold).

Unmapped (no source location) — 1 violation (1 serious)
Impact Rule Source Element Message
🟧 serious navigable/link-name #label-987ef8 Link has no discernible text.

https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/Software/Available_Applications/AlphaFold/

12 violations: 🟧 12 serious (+61 below threshold).

Unmapped (no source location) — 12 violations (12 serious)
Impact Rule Source Element Message
🟧 serious distinguishable/link-in-text-block a[href="https://github.com/deepmind/alphafold/issues/32"] Link in text block is not visually distinguishable from surrounding text. Add a non-color visual indicator such as an underline or border.
🟧 serious distinguishable/color-contrast span:nth-of-type(7) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(5) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(5) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(3) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(8) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(13) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(3) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious distinguishable/color-contrast span:nth-of-type(8) Insufficient color contrast ratio of 4.48:1 (required 4.5:1).
🟧 serious navigable/link-name a:nth-of-type(1) Link has no discernible text.
🟧 serious navigable/link-name a[href="https://github.com/deepmind/alphafold#alphafold-code-license"] Link has no discernible text.
🟧 serious navigable/link-name a[href="https://github.com/deepmind/alphafold#model-parameters-license"] Link has no discernible text.

https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/audit-fix/Software/Available_Applications/Dorado/

1 violation: 🟧 1 serious (+43 below threshold).

Unmapped (no source location) — 1 violation (1 serious)
Impact Rule Source Element Message
🟧 serious navigable/link-name a[href="https://github.com/nanoporetech/dorado#features"] Link has no discernible text.

Generated 2026-07-13T04:52:31.635Z · run log · AccessLint/audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant