Add template system for toolchain packages#150
Open
fhunleth wants to merge 5 commits into
Open
Conversation
The toolchains are all the same, so create their packages rather than have n copies. This adds a Makefile to create the packages from a common template. Since everything is in a template, there's no need to have shared code in nerves_toolchain_ctng. This removes one dependency that would force all Nerves systems to upgrade in lock step. This also removes the back-and-forth between the Nerves tooling to create the artifact. The code in Nerves was only the creation of the tarball which was such a minimal part that replicating here instead of calling the shared code simplifies everything. It also means that building the artifact is a process of calling the `build.sh` script in the base directory rather than running `mix nerves.artifact`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolchains are all the same, so create their packages rather than
have n copies. This adds a Makefile to create the packages from a common
template. Since everything is in a template, there's no need to have
shared code in nerves_toolchain_ctng. This removes one dependency that
would force all Nerves systems to upgrade in lock step.
This also removes the back-and-forth between the Nerves tooling to
create the artifact. The code in Nerves was only the creation of the
tarball which was such a minimal part that replicating here instead of
calling the shared code simplifies everything. It also means that
building the artifact is a process of calling the
build.shscript inthe base directory rather than running
mix nerves.artifact.