examples: add monitor_and_probe example for netwatch and portmapper integration - #192
examples: add monitor_and_probe example for netwatch and portmapper integration#192alpn wants to merge 4 commits into
Conversation
…ocessing watcher items while probing
flub
left a comment
There was a problem hiding this comment.
Honestly looking at this example I'm not really sure it explains that much more. I'm mostly wondering about all the various ways of doing the concurrency during the review, there is very little actual clarification about the API. It's all about how to use tokio.
Also, what happens when you start a new probe while one was already in progress?
- use let-else pattern instead of match
- document exit condition
Well the reason I decided to add this example was because I couldn't figure out how to use this API without reading the code. I'm happy to add this stuff to each crate's respective README as well.
This shouldn't be possible. A new probe could only be triggered by a network state change, in which case the currently running probe (if any) gets cancelled since our |
Description
Add a new example demonstrating integration of netwatch and portmapper for monitoring network changes and probing port mapping support on the default route interface.
Breaking Changes
None
Notes & open questions
None
Change checklist