Compile Sigstore trust bootstrap into AppUpdater - #24
Closed
mxcl wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Bundle.modulerelied on SwiftPM's generated resource accessor. The manually assembled macOS smoke app copied the bundle intoContents/Resources, but the accessor searched beside the app bundle and then fell back to the original build directory. That fallback made the smoke test pass while a relocated release app crashed loading the trust bootstrap.Security impact
The compiled trust bootstrap is byte-for-byte identical to AppUpdater 4.1.0's resources. TUF rotation, metadata verification, and the existing offline fallback policy are unchanged; this only removes the runtime packaging dependency.
Checks
swift test— 75 tests passedAppUpdater_AppUpdater.bundleAutomic-Vault-2.10.0.dmgprepared successfully with.buildabsent