Skip to content

Adjust the compiler flags in the meson script#253

Closed
amaa-99 wants to merge 1 commit into
mvo5:masterfrom
amaa-99:135-adjust-the-compiler-flags-in-the-meson-script
Closed

Adjust the compiler flags in the meson script#253
amaa-99 wants to merge 1 commit into
mvo5:masterfrom
amaa-99:135-adjust-the-compiler-flags-in-the-meson-script

Conversation

@amaa-99

@amaa-99 amaa-99 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Set the builttype to plain, to avoid Meson's defaults.
Reset the warning level to the one used with automake.
Set the c++ standard to c++17.
(Re)enabled the optimization options.

(closes amaa-99#135)

@amaa-99

amaa-99 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@mvo5 Do you think we could bump the c++ standard to c++20 or c++23?
(I guess you have a better overview of where do this have to be compilable 😉)

@amaa-99

amaa-99 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@mvo5 My plan would be to enable more and more of the warnings in a granular way as I go through the code issues.
For now I'd keep it as before the meson migration, so that we can easily see if new warnings pop in.
p.s. Meson doesn't have granular control for warnings or optimization options (I guess it will eventually get there, after they sift through their 1.8K open issues). I therefore took the approach of explicitly adding whatever is wanted/needed and suppressing as much as practical the defaults injected by the python tool.

@andy128k

Copy link
Copy Markdown
Contributor

What's the point of O3 and lto? This is just a GUI application where heavy-lifting happens in libraries.

@amaa-99
amaa-99 force-pushed the 135-adjust-the-compiler-flags-in-the-meson-script branch from 3b40c13 to 633e171 Compare July 17, 2026 19:53
Set the builttype to plain, to avoid Meson's defaults.
Reset the warning level to the one used with automake.
Set the c++ standard to c++17.
(Re)enabled the optimization options.
@amaa-99
amaa-99 force-pushed the 135-adjust-the-compiler-flags-in-the-meson-script branch from 633e171 to 2b298c1 Compare July 17, 2026 19:57
@amaa-99

amaa-99 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Dropping this for now (will keep using optimizations on my fork though - it cuts down on the UI latencies.

@amaa-99 amaa-99 closed this Jul 17, 2026
@amaa-99
amaa-99 deleted the 135-adjust-the-compiler-flags-in-the-meson-script branch July 17, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust the compiler flags in the meson script

2 participants