Fix client crash from invalid sound FFT band counts#5048
Open
HeresHavi wants to merge 1 commit into
Open
Conversation
Validate FFT band counts before extracting or allocating spectrum data to prevent negative and oversized values from crashing the client or reading beyond the available FFT data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added FFT band-count validation for sound elements and player voice.
Band counts from zero through half the requested FFT sample count remain valid. Negative values and values above the available half-spectrum now return
falsebefore FFT extraction or allocation.Motivation
getSoundFFTDataaccepted any signed band count. A value of-1reachednew float[iBands]and became an extremely large allocation request, causing MTA's out-of-memory handler to terminate the client.For example, a resource might use FFT data to draw a music visualizer and allow the number of bands to come from a setting. If that value becomes negative or exceeds the available spectrum, the old code could terminate the player's client or read beyond the FFT data.
The reported out-of-memory error was caused by the invalid allocation size. The machine had not actually run out of memory.
Crash Stack
Test plan
Runtime
bands = -1terminated the client through the out-of-memory handler.false, and the client stayed open.bands = 128returned a table containing 128 entries.bands = 129returnedfalse, and the client stayed open.Builds and Tests
Debug | Win32: Full build passed, 304 client tests passed.Release | Win32: Full build passed, 304 client tests passed.Debug | x64: Full build passed.Release | x64: Full build passed.clang-format.Checklist