Fix chat scale loading and precision#5036
Open
HeresHavi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Chat Scale loading the first stored value into both X and Y.
Both values now load independently and keep their saved precision.
Motivation
The settings loader rounded the first scale value to one decimal place and used it for both fields. This changed non-uniform chat scales whenever the settings were loaded and saved.
For example, the bundled Race Oversized preset uses
1.65 × 1.17. The old loader changed it to1.6 × 1.6, losing both the separate Y value and the original precision.Fixes #5035.
Test plan
Runtime
1.65 1.17loaded and saved as1.6 × 1.6.1.65 × 1.17and survived saving and restarting MTA.0.5to3range.1 × 1scale.Builds and Tests
Debug | Win32: Client Core build passed, 304 client tests passed.Release | Win32: Client Core build passed, 304 client tests passed.Checklist