Fix chat preset colors without an alpha value#5034
Open
HeresHavi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed chat preset colors without an alpha value loading as fully transparent.
RGB-only colors now default to an alpha value of
255, while colors with an explicit alpha keep their saved value. Presets with invalid RGB values are ignored.Motivation
The preset loader always tried to read four color values. When a preset only contained RGB values, reading the missing alpha failed and the color was applied with a transparency value of
0.For example, loading the bundled MTA Blue preset changed Chat Text to
255 255 255 0, making the preview fully transparent.Fixes #5033.
Test plan
Runtime
255 255 255 0.255 255 255 255, and white chat text remained visible in-game.172 213 254 255color.10 invalid 30left the existing color unchanged.255 255 255 255remained saved.Builds and Tests
Debug | Win32: Client Core build passed, 304 client tests passed.Release | Win32: Full solution build passed, 304 client tests passed.Checklist