Fix disabled server browser tabs being restored as enabled#5032
Open
HeresHavi wants to merge 2 commits into
Open
Fix disabled server browser tabs being restored as enabled#5032HeresHavi wants to merge 2 commits into
HeresHavi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed server browser tabs configured with
disabled="1"being restored as enabled.Tabs using
disabled="0"or nodisabledattribute remain enabled, and normal shutdown now preserves the intended state.Motivation
The saved value describes whether a tab is disabled, but it was passed directly to
SetEnabled, which expects the opposite value. This inverted the tab state when MTA loaded its configuration.For example, someone could disable the Local server browser tab in
coreconfig.xml, launch MTA, and find that the tab was still usable. Closing MTA could then remove the original setting because the incorrect state was saved back.Fixes #5031.
Test plan
Runtime
disabled="1"left the Local tab enabled, and normal shutdown removed the attribute.disabled="1"disabled the Local tab and remained saved after shutdown.disabled="0"previously disabled the tab but now leaves it enabled.disabledattribute left all server browser tabs enabled.disabled="0"attribute was removed during normal shutdown without changing the enabled state.Builds and Tests
Debug | Win32: Client Core build passed, 304 client tests passed.Release | Win32: Full solution build passed, 304 client tests passed.Checklist