Preserve client console scroll position when trimming history#5030
Open
HeresHavi wants to merge 1 commit into
Open
Preserve client console scroll position when trimming history#5030HeresHavi wants to merge 1 commit into
HeresHavi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserved the visible F8 console position when new output causes older history to be removed.
The console still follows new output while viewing the bottom, and trimming now handles wrapped and multibyte text correctly.
Motivation
The console keeps a limited amount of history. When that limit was reached, older lines were removed from the top while the previous scrollbar position was restored unchanged. This made the visible content jump forward even though the user had scrolled back to read earlier output.
For example, a developer may scroll up to inspect an earlier error while a busy resource continues printing messages. Once the history starts trimming, the console could move away from the lines they were reading.
Test plan
Runtime
éand界. The text stayed intact and the viewport did not move.Builds and Tests
Debug | Win32: Client tests built, 304 tests passed.Release | Win32: Full solution build passed, 304 client tests passed.Release | x64: Server build passed.clang-format.Checklist