fix: use-after-free in get_data_from_buffer#677
Open
KowalskiThomas wants to merge 3 commits into
Open
Conversation
KowalskiThomas
force-pushed
the
kowalski/fix-uaf-step-1
branch
from
882aa38 to
9845e8e
Compare
KowalskiThomas
force-pushed
the
kowalski/fix-uaf-step-1
branch
from
2af2d1f to
eae29a9
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a crash (use-after-free) when unpacking from non-contiguous buffer inputs (e.g., sliced memoryview), and adds a regression test to ensure the behavior stays correct across future changes.
Changes:
- Add a regression test that unpacks from a non-contiguous stride-2
memoryview. - Adjust C-extension buffer handling in
get_data_from_bufferto avoid premature deallocation. - Update the pure-Python fallback
Unpacker.feed()to safely handle non-contiguousmemoryviewinputs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/test_memoryview.py |
Adds a regression test covering unpacking from non-contiguous memoryview. |
msgpack/fallback.py |
Ensures fallback Unpacker.feed() can ingest non-contiguous memoryview inputs. |
msgpack/_unpacker.pyx |
Updates contiguous-copy buffer acquisition logic to prevent use-after-free. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Check PyObject_GetBuffer return value and raise on failure - Avoid unnecessary tobytes() copy for contiguous memoryviews in fallback feed()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
There currently is a crash happening when unpacking data from a non-contiguous input.
The current PR adds a test to confirm the problem is not happening anymore as well as the fix itself.
Running the reproducer with the fix applied makes the crash go away.
This is a reproducer:
Running it results in the following: