Skip to content

fix(config-rom): reject suspended generation exports#87

Draft
gly11 wants to merge 5 commits into
mrmidi:mainfrom
gly11:sbp2/config-rom-generation-safety
Draft

fix(config-rom): reject suspended generation exports#87
gly11 wants to merge 5 commits into
mrmidi:mainfrom
gly11:sbp2/config-rom-generation-safety

Conversation

@gly11

@gly11 gly11 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make ConfigROM selector 14 reject suspended cache entries
  • preserve explicit suspended-cache access for internal lifecycle callers
  • add a regression test for the exact-generation filtered lookup

Problem

ExportConfigROM documents exact-generation lookup with no stale fallback, but
it called the ConfigROMStore overload that returns suspended entries. A bus
reset between a client generation read and selector 14 could therefore return
a complete ROM from the previous generation and let the client reuse stale
node routing information.

Fix

Use FindByNode(generation, node, false) in the user-client handler. The existing
not-cached path then returns empty data for suspended entries, while internal
callers can still opt into suspended cache access.

Verification

  • ConfigROMStoreConcurrencyTests: 8 passed
  • GitHub Build and Test check: passed
  • git diff --check
  • no dext build, install, or hardware mutation was required

CI organization

Shared CI workflow cleanup is tracked separately in #88. After #88 merges, this branch should be rebased onto main so the duplicated CI commits can be dropped cleanly.

@gly11
gly11 force-pushed the sbp2/config-rom-generation-safety branch from 4629038 to 808c5a4 Compare July 26, 2026 10:31
@gly11
gly11 force-pushed the sbp2/config-rom-generation-safety branch from 808c5a4 to a0cfbcf Compare July 26, 2026 10:43
@gly11
gly11 marked this pull request as ready for review July 26, 2026 13:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b59542c8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ASFWDriver/UserClient/Handlers/ConfigROMHandler.cpp
@gly11
gly11 marked this pull request as draft July 26, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant