fix(config-rom): reject suspended generation exports#87
Draft
gly11 wants to merge 5 commits into
Draft
Conversation
gly11
force-pushed
the
sbp2/config-rom-generation-safety
branch
from
July 26, 2026 10:31
4629038 to
808c5a4
Compare
gly11
force-pushed
the
sbp2/config-rom-generation-safety
branch
from
July 26, 2026 10:43
808c5a4 to
a0cfbcf
Compare
gly11
marked this pull request as ready for review
July 26, 2026 13:57
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b59542c8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gly11
marked this pull request as draft
July 26, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
ExportConfigROM documents exact-generation lookup with no stale fallback, but
it called the ConfigROMStore overload that returns suspended entries. A bus
reset between a client generation read and selector 14 could therefore return
a complete ROM from the previous generation and let the client reuse stale
node routing information.
Fix
Use FindByNode(generation, node, false) in the user-client handler. The existing
not-cached path then returns empty data for suspended entries, while internal
callers can still opt into suspended cache access.
Verification
git diff --checkCI organization
Shared CI workflow cleanup is tracked separately in #88. After #88 merges, this branch should be rebased onto
mainso the duplicated CI commits can be dropped cleanly.