Bug 2054039 - Add a button to clear all screen notifications - #9687
Bug 2054039 - Add a button to clear all screen notifications#9687davidmiculit wants to merge 2 commits into
Conversation
| <Button | ||
| onClick={() => clearAllNotifications()} | ||
| className="clear-all-notifications w-100 mb-1" | ||
| size="sm" | ||
| > | ||
| Clear all notifications | ||
| </Button> |
There was a problem hiding this comment.
Functionality is all right
That blue background stands out too much imo, this styling is used for tags.
I would go for maybe variant="darker-info", it looks better on jobs view, it overlaps with Table view and Add test data buttons in graphs view, I'm not sure. What do you think?
Or something that is not that bright in color and is similar with the other buttons in Perfherder.
There was a problem hiding this comment.
Maybe we could add a keyboard shortcut for this
There was a problem hiding this comment.
I agree that it could look better, but the overlapping will still be present as long as any notifications are on screen(even without the clear all button), so that can't be helped
|
Closed and continued on #9730, as feature scope changed. |
2 participants
Bug 2054039 - Add a button to clear all screen notifications