Remove the unused key3 parameter from the various Dict get-methods - #21815
Remove the unused key3 parameter from the various Dict get-methods#21815Snuffleupagus wants to merge 1 commit into
key3 parameter from the various Dict get-methods#21815Conversation
PR 20542 removed the only spot in the code-base where a `Dict` get-method was invoked with three keys, hence we can remove a little bit of effectively dead code. Note that for any "regular" `Dict` lookup there can be at most two keys, since some PDF properties have shorthand names (e.g. /CS respectively /ColorSpace).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21815 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 264 264
Lines 67339 67335 -4
=======================================
- Hits 60741 60738 -3
+ Misses 6598 6597 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8eca4f2358ff526/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7970b48e9ec5c57/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8eca4f2358ff526/output.txt Total script time: 18.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7970b48e9ec5c57/output.txt Total script time: 23.42 mins
|
PR #20542 removed the only spot in the code-base where a
Dictget-method was invoked with three keys, hence we can remove a little bit of effectively dead code.Note that for any "regular"
Dictlookup there can be at most two keys, since some PDF properties have shorthand names (e.g. /CS respectively /ColorSpace).