Skip to content

Remove the unused key3 parameter from the various Dict get-methods - #21815

Open
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:Dict-get-rm-key3
Open

Remove the unused key3 parameter from the various Dict get-methods#21815
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:Dict-get-rm-key3

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

PR #20542 removed the only spot in the code-base where a Dict get-method was invoked with three keys, hence we can remove a little bit of effectively dead code.

Note that for any "regular" Dict lookup there can be at most two keys, since some PDF properties have shorthand names (e.g. /CS respectively /ColorSpace).

PR 20542 removed the only spot in the code-base where a `Dict` get-method was invoked with three keys, hence we can remove a little bit of effectively dead code.

Note that for any "regular" `Dict` lookup there can be at most two keys, since some PDF properties have shorthand names (e.g. /CS respectively /ColorSpace).
@Snuffleupagus
Snuffleupagus deployed to code-coverage August 23, 2026 10:02 — with GitHub Actions Active
@codecov-commenter

codecov-commenter commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.20%. Comparing base (0f26334) to head (2ae5995).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21815   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         264      264           
  Lines       67339    67335    -4     
=======================================
- Hits        60741    60738    -3     
+ Misses       6598     6597    -1     
Flag Coverage Δ
browsertest 66.31% <100.00%> (-0.02%) ⬇️
fonttest 8.91% <0.00%> (+<0.01%) ⬆️
integrationtest 69.40% <100.00%> (+<0.01%) ⬆️
unittest 58.36% <100.00%> (-0.01%) ⬇️
unittestcli 56.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8eca4f2358ff526/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7970b48e9ec5c57/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8eca4f2358ff526/output.txt

Total script time: 18.09 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/7970b48e9ec5c57/output.txt

Total script time: 23.42 mins

  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants