Skip to content

Avoid zooming during fast two-finger panning - #21807

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:touch/no-pinch-while-panning
Aug 21, 2026
Merged

Avoid zooming during fast two-finger panning#21807
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:touch/no-pinch-while-panning

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Round scale updates and carry rounding error. Filter span changes consistent with staggered touch samples.

@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.19%. Comparing base (3cb74c4) to head (e05ab5e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21807   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         264      264           
  Lines       67332    67350   +18     
=======================================
+ Hits        60724    60746   +22     
+ Misses       6608     6604    -4     
Flag Coverage Δ
browsertest 66.33% <0.00%> (+0.01%) ⬆️
fonttest 8.91% <ø> (ø)
integrationtest 69.39% <82.60%> (+0.01%) ⬆️
unittest 58.35% <100.00%> (-0.01%) ⬇️
unittestcli 56.94% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comment addressed. Thanks!

Comment thread src/display/touch_manager.js
Round scale updates and carry rounding error. Filter span changes consistent with staggered touch samples.
@calixteman
calixteman merged commit 9aea8e2 into mozilla:master Aug 21, 2026
21 checks passed
@calixteman
calixteman deleted the touch/no-pinch-while-panning branch August 21, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants