Move editToolbar and fix overlapping annotations with it - #21723
Open
LoukasPap wants to merge 5 commits into
Open
Move editToolbar and fix overlapping annotations with it#21723LoukasPap wants to merge 5 commits into
LoukasPap wants to merge 5 commits into
Conversation
LoukasPap
marked this pull request as draft
August 6, 2026 20:49
Author
|
This is currently a draft because I haven't yet added the integration tests. I pushed anyway to make sure we agree with the solution and then move on. |
LoukasPap
force-pushed
the
fix/link-overlaps-floating-toolbar
branch
2 times, most recently
from
August 6, 2026 20:58
7c9c34c to
c48cbd1
Compare
LoukasPap
force-pushed
the
fix/link-overlaps-floating-toolbar
branch
from
August 19, 2026 15:49
0d85a6a to
f1d551a
Compare
LoukasPap
force-pushed
the
fix/link-overlaps-floating-toolbar
branch
from
August 19, 2026 16:01
f1d551a to
356901b
Compare
LoukasPap
marked this pull request as ready for review
August 19, 2026 16:03
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
LoukasPap
temporarily deployed
to
code-coverage
August 20, 2026 20:08 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21723 +/- ##
===========================================
- Coverage 90.19% 75.75% -14.44%
===========================================
Files 264 264
Lines 67324 67327 +3
===========================================
- Hits 60721 51005 -9716
- Misses 6603 16322 +9719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21643
I moved the editToolbar up to page level and added
isolation: isolateto.annotationLayer,.annotationEditorLayerand.editor toolbarelements so that z-index works at their level. That way we avoid the z-index of a nested annotation (e.g. a linkAnnotation) "compete" with the z-index of the editToolbar.This PR also fixes a bug where a textAnnotation was rendered above the editToolbar.
Tests
I used
document.elementFromPoint(x,y)to check every time which elements is rendered on top.I also moved createFreeTextEditor() to
test_utils.mjsto make it available to all tests that may need itTest 1 — "the edit toolbar is rendered above link annotations"
Test 2 — "the edit toolbar is rendered above text annotations"