feat(headers): add optional dropdown to pick header names and values#489
Open
WkdXeqtr wants to merge 5 commits into
Open
feat(headers): add optional dropdown to pick header names and values#489WkdXeqtr wants to merge 5 commits into
WkdXeqtr wants to merge 5 commits into
Conversation
Adds an opt-in chevron dropdown next to header name and value inputs that lists the same suggestions as the inline autocomplete, so values can be picked without knowing what to type. Off by default, toggled in Settings -> Interface -> Editor. Long values like User-Agent show a short label but insert the full string via the completion apply field.
Member
|
JUst added this to the PR template (for future PRs), but can you please attach screenshots or a screen recording of this? I would also consider it a feature, not a small-scoped improvement, but I'm willing to consider it if it fits the vibe of Yaak. |
Author
|
Thanks for taking a look! Screenshots below. The setting (off by default, Settings -> Interface -> Editor):
A header field with it off (unchanged, no chevron) vs on:
Picking a value from the dropdown:
|
Member
|
Thanks for that! I wasn't sure I'd like this at first but, now that I see it, I think I do :) Going to review and get this in for the next release |
github-actions
Bot
added
the
contribution: policy unmet
gschier
added
contribution: explicit permission
github-actions
Bot
added
contribution: policy unmet
gschier
added
contribution: explicit permission
github-actions
Bot
added
contribution: policy unmet
gschier
added
contribution: in scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm migrating from Advanced REST Client (ARC), where header fields had a dropdown
of common names and values, so you could pick one without knowing the exact string
up front. Yaak already has inline autocomplete for headers - this PR adds an
optional dropdown on top of it, so the same suggestions are discoverable by
clicking, not only by typing.
It is fully opt-in and off by default
(Settings -> Interface -> Editor -> "Header suggestion dropdowns"), so nothing
changes unless you turn it on. When enabled, a small chevron appears on the header
name and value inputs; picking an item inserts it. Inline autocomplete is left
untouched.
The dropdown reuses Yaak's existing header suggestion data (header names, mime
types, encodings, ...) and adds a few common value lists (Cache-Control,
Accept-Language, User-Agent). For values that are long or hard to remember, like
User-Agent, it shows a short label (e.g. "Chrome 120 - Windows") but inserts the
full string, using the completion's
applyfield so inline autocomplete shows thesame labels.
Submission
CONTRIBUTING.md.Approved feedback item (required if not a bug fix or small-scope improvement):
Related