-
Notifications
You must be signed in to change notification settings - Fork 2
moq-lite-05: SETUP message + negotiated Probe capability levels #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+145
−40
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probe failure behavior conflicts with the probe extension draft.
Here unsupported Probe results in stream reset, but the provided
draft-lcurley-moq-probe.mdsnippet requires session close withPROTOCOL_VIOLATIONwhen a subscriber opens PROBE without negotiated support. This cross-draft mismatch will cause interop splits.Please align the normative outcome between drafts (either reset-stream or session-close) and keep both documents identical on this point.
Also applies to: 586-587
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This divergence is intentional: the two drafts target different host protocols with different error models. moq-lite resets unknown/unsupported streams non-fatally (its core STREAM_TYPE rule), so stream reset is the correct, in-philosophy outcome here. moq-probe targets moq-transport, where Section 3.3 mandates closing the session with PROTOCOL_VIOLATION when a bidirectional stream begins with an un-negotiated message type. Making them identical would violate one host spec. Leaving this thread open for a maintainer call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kixelated, thanks for the clear explanation — that makes sense. The error model is inherited from the host protocol in each case, so the divergence is load-bearing, not accidental. I'll note this for future reviews.✏️ Learnings added
🧠 Learnings used